Repository navigation
feat(site): add bulk delete for tasks - #20905
Conversation
e90e182 to
fecb385
Compare
aslilac
left a comment
aslilac
left a comment
There was a problem hiding this comment.
I feel like the text/stages could use a little more tweaking. I expect people to care a lot less about what terraform resources are being destroyed when deleting a task than they would when deleting workspaces that people actually ssh into.
and as danielle was saying, I definitely think we should convert the styles to tailwind. the goal has been "no new emotion styles, full stop" for quite a while. this would even be a good opportunity to convert the styles of the components these are taking from. leave the campsite better than you found it!
166b19d to
e9b3b69
Compare
e9b3b69 to
89dd770
Compare
|
@aslilac @DanielleMaywood I believe I've addressed your feedback. PTAL (I haven't approved Chromatic changes yet so you can check those out too.) Also: #20946 |
|
Looks like the styling is a little different between the tasks page and workspaces page when selecting them all. 
|
|
@DanielleMaywood could you highlight the difference? I don't see it. |
On the tasks page, when you bulk select the rows change color, when they don't on the workspaces page. Notice the rows have a different color in the screenshots |
|
Ah, nvm. See it now. The color changes. Not sure if it's better or worse but I can align. |
1584949 to
af188b1
Compare
DanielleMaywood
left a comment
DanielleMaywood
left a comment
There was a problem hiding this comment.
From my side I'm happy
Add comprehensive documentation for active frontend pattern migrations discovered through analysis of 200+ git commits touching site/ files: Core Migrations: - Emotion → Tailwind CSS (strict 'no new emotion' policy) - MUI Components → Custom/Radix/shadcn (Tooltips, Tables, Buttons) - MUI Icons → lucide-react with specific icon mappings - spyOn → queries parameter for GET endpoint mocks in Storybook - localStorage → user_configs table for user preferences New Documentation: - Icon migration mappings (BusinessIcon→Building2Icon, etc.) - Radix component prop naming conventions (placement→side) - cn() utility usage for conditional className merging - Chromatic testing best practices (prefer snapshots over assertions) Includes concrete before/after examples and migration patterns to guide developers away from deprecated approaches toward current best practices. Analysis based on PRs: #20948, #20946, #20938, #20905, #20900, #20869, #20849, #20808, #20530, #20479, #20261, #20201, #20200, #20193, #20318 --- 🤖 This change was written by Claude Sonnet 4.5 Thinking using mux and reviewed by a human 🏂
This change implements bulk delete for tasks, closely copying UI and components from workspaces batch actions.
Since workspace batch actions are behind a feature, we add one for tasks as well.
Fixes coder/internal#1088
🤖 PR was written by Claude Sonnet 4.5 Thinking and reviewed by a human 🏂🏻