Repository navigation
fix: remove inflight interceptions from aibridge returned values - #20852
Merged
Merged
Conversation
mtojek
reviewed
Nov 21, 2025
dannykopping
left a comment
dannykopping
left a comment
Contributor
There was a problem hiding this comment.
@jakehwll we never make changes without tests to validate.
Please can you add some to cover each query?
Contributor
Author
Yeah this was meant to Draft PR oops |
jakehwll
marked this pull request as draft
November 23, 2025 22:53
jakehwll
marked this pull request as ready for review
November 24, 2025 12:18
dannykopping
left a comment
dannykopping
left a comment
Contributor
There was a problem hiding this comment.
Looks good, a couple small things to fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
aibridge#54When querying against the values in the database for
/api/experimental/aibridge/interceptionswe found strange behaviour wherein there was interceptions that lacked prompting and other various fields we want. Generally this was as a result of the data not actually existing for these values (as they were inflight).The simple solution to this was to hide them if they didn't exist. This PR addresses that.