Skip to content

test(coderd/workspaceapps/apptest): fix lastusedat assertion for all test - #20827

Merged
mafredri merged 1 commit into
mainfrom
mafredri/test-fix-app-proxyerror-test
Nov 19, 2025
Merged

mafredri merged 1 commit into
mainfrom
mafredri/test-fix-app-proxyerror-test

Conversation

@mafredri

@mafredri mafredri commented Nov 19, 2025 •

Copy link
Copy Markdown
Member

The test flake can be verified by setting ReportInterval to a really
low value, like 100 * time.Millisecond.

Fixes coder/internal#960
Fixes coder/internal#975

…test

The test flake can be verified by setting `ReportInterval` to a really
low value, like `100 * time.Millisecond`.

Fixes coder/internal#960
Fixes coder/internal#975
@mafredri
mafredri force-pushed the mafredri/test-fix-app-proxyerror-test branch from c566d38 to 1234da8 Compare November 19, 2025 11:53

@DanielleMaywood DanielleMaywood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't really got much context for this but happy to approve assuming all tests continue to pass.

@mafredri
mafredri merged commit f6556fc into main Nov 19, 2025
29 checks passed
@mafredri
mafredri deleted the mafredri/test-fix-app-proxyerror-test branch November 19, 2025 13:11
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flake: TestWorkspaceProxyWorkspaceApps/WorkspaceAppsProxySubdomain/ProxyError flake: TestWorkspaceApps/WorkspaceAppsProxySubdomain/ProxyError

2 participants