Repository navigation
chore: protect build timings insert for invalid enums - #20821
Merged
Merged
Conversation
dannykopping
approved these changes
Nov 19, 2025
dannykopping
left a comment
dannykopping
left a comment
Contributor
There was a problem hiding this comment.
LGTM, would be interesting to see if this is expected PG behaviour or a libpq bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You get this error when an insert fails:
Database insert errors will fail the transaction. So this error is fatal. Properly return it for a better error call stack, and not just hiding the error in the logs.
Error
I broke something in a side branch, and this was the error. Pretty opaque, debugged it down to what you see in this PR. This fixes it in prod by skipping the timing. It also makes the insert a fatal error.