Repository navigation
feat: fix build timeline to include entire stage timings - #20805
Merged
Merged
Conversation
Emyrk
changed the title
Emyrk
marked this pull request as ready for review
November 17, 2025 17:46
Emyrk
force-pushed
the
stevenmasley/wholetimings
branch
from
November 17, 2025 19:22
e80baae to
89cc16c
Compare
Member
Author
|
@dannykopping the storybook failures are happening in I am watching this PR with fixes: #20808 |
Emyrk
force-pushed
the
stevenmasley/wholetimings
branch
from
November 18, 2025 16:32
73687e5 to
80631df
Compare
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 18, 2025
dannykopping
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a "bug" in build timlines. The timelines are populated by discrete events. These events may not inherently include the actual total time for a given stage (plan, apply, graph, etc). Ideally we would measure the total time for a given terraform execution stage, then populate the timeline with the discrete events.
See this live example. The stages are:
init= 11.47splan=864msgraph=10.06sapply= 23.88s46.27s is the total duration summed, however the timings suggest this took >1m.
Where was the ~14+ seconds taken? Without full stage timings, we are not really sure.
Fix example
This is the exact same build timings, with the stage boundary entry removed in the
Before. You can seeplangoes from462ms -> 727msandapplyfrom552ms -> 900ms.Before
After
Future work
graphstage is currently not using this method. Because there is 2 graph stages, and they have to be distinct. Working on this in another PRUI Demo
Screencast.From.2025-11-17.11-38-16.webm