Repository navigation
refactor: use task data model for notifications - #20590
Merged
mafredri merged 2 commits intoOct 31, 2025
Merged
Conversation
mafredri
commented
Oct 30, 2025
mafredri
force-pushed
the
mafredri/refactor-use-task-data-model-for-notifications
branch
from
October 30, 2025 16:57
d379e17 to
841cb33
Compare
johnstcn
reviewed
Oct 30, 2025
Emyrk
reviewed
Oct 30, 2025
Comment on lines
-55
to
+70
| AllowIDList: []AllowListElement{ | ||
| AllowIDList: append([]AllowListElement{ | ||
| {Type: ResourceWorkspace.Type, ID: params.WorkspaceID.String()}, | ||
| {Type: ResourceTemplate.Type, ID: params.TemplateID.String()}, | ||
| {Type: ResourceTemplate.Type, ID: params.VersionID.String()}, | ||
| {Type: ResourceUser.Type, ID: params.OwnerID.String()}, | ||
| }, | ||
| }, extraAllowList...), |
Member
There was a problem hiding this comment.
This is nice and narrow 👍
Just for future info, you can also do this: {Type: ResourceTask.Type, ID: policy.WildcardSymbol},
To give it access to all tasks. I assume each workspace just has 1 task though. And being narrow is better 👍
Member
Author
There was a problem hiding this comment.
Yep, tasks and workspaces are 1:1 currently. Good to know about the wildcard though, thanks. 👍🏻
johnstcn
approved these changes
Oct 31, 2025
mafredri
deleted the
mafredri/refactor-use-task-data-model-for-notifications
branch
October 31, 2025 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates coder/internal#973
Updates coder/internal#974