Skip to content

feat: add task status reporting load generator runner - #20538

Merged
spikecurtis merged 1 commit into
mainfrom
spike/internal-913-taskstatus-runner
Nov 13, 2025
Merged

spikecurtis merged 1 commit into
mainfrom
spike/internal-913-taskstatus-runner

Conversation

@spikecurtis

@spikecurtis spikecurtis commented Oct 29, 2025 •

Copy link
Copy Markdown
Contributor

Adds the Runner, Config, and Metrics for the scaletest load generator for task status.

Part of coder/internal#913

spikecurtis commented Oct 29, 2025 •

Copy link
Copy Markdown
Contributor Author

@spikecurtis
spikecurtis marked this pull request as ready for review October 29, 2025 12:06
@spikecurtis
spikecurtis force-pushed the spike/internal-913-taskstatus-runner branch from 6301335 to 6d573a2 Compare October 29, 2025 12:19

@ethanndickson ethanndickson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nitpicks from me

Comment thread scaletest/taskstatus/config.go Resolved
Comment thread scaletest/taskstatus/config.go Resolved
MetricLabelValues []string `json:"metric_label_values"`
}

func (c *Config) Validate() error {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks unused

Comment thread scaletest/taskstatus/run.go Resolved
Comment thread scaletest/taskstatus/run.go Resolved
@spikecurtis
spikecurtis changed the base branch from spike/scaletest-refactor-workspace-target-flags to graphite-base/20538 October 30, 2025 07:10
@spikecurtis
spikecurtis force-pushed the spike/internal-913-taskstatus-runner branch from 6d573a2 to 8bafc4f Compare October 30, 2025 07:10
@graphite-app
graphite-app Bot changed the base branch from graphite-base/20538 to main October 30, 2025 07:11
@spikecurtis
spikecurtis force-pushed the spike/internal-913-taskstatus-runner branch from 8bafc4f to bd4b0c6 Compare October 30, 2025 07:11
@github-actions github-actions Bot added stale This issue is like stale bread. and removed stale This issue is like stale bread. labels Nov 7, 2025
@spikecurtis
spikecurtis force-pushed the spike/internal-913-taskstatus-runner branch from bd4b0c6 to a606f12 Compare November 13, 2025 10:25
@spikecurtis
spikecurtis force-pushed the spike/internal-913-taskstatus-runner branch from a606f12 to 1a891c3 Compare November 13, 2025 12:12
@spikecurtis
spikecurtis merged commit a3c851c into main Nov 13, 2025
26 checks passed
@spikecurtis
spikecurtis deleted the spike/internal-913-taskstatus-runner branch November 13, 2025 12:53
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants