Repository navigation
fix(site): fix disappearing preset selector when switching template - #20514
Merged
Merged
Conversation
DanielleMaywood
marked this pull request as ready for review
October 28, 2025 14:31
johnstcn
approved these changes
Oct 28, 2025
johnstcn
left a comment
johnstcn
left a comment
Member
There was a problem hiding this comment.
LGTM, but will happily defer to other reviewers' feedback.
Member
|
the |
Contributor
Author
|
@aslilac I've re-added the |
aslilac
approved these changes
Oct 28, 2025
aslilac
left a comment
aslilac
left a comment
Member
There was a problem hiding this comment.
I'm fine with this fix, but left some food for thought and would like to see a comment or something describing the pitfalls that the fix is supposed to smooth over
johnstcn
added
the
cherry-pick/v2.28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20465
Ensure we set
selectedPresetIdtoundefinedwhen we changeselectedTemplateIdto ensure we don't end up breaking the<Select>component by giving it an invalid preset id.