Skip to content

fix: improve visual separation between prompt and task list - #20427

Merged
aslilac merged 3 commits into
mainfrom
fix-tasks-page-separator
Oct 29, 2025
Merged

aslilac merged 3 commits into
mainfrom
fix-tasks-page-separator

Conversation

@bartekgatzcoder

Copy link
Copy Markdown
Contributor

Summary

This PR improves the visual separation between the task prompt form and the task list by adding a border separator and increased padding to the controls section.

Changes

  • Added border-t border-border to create a faint horizontal line separator
  • Added pt-6 to increase spacing above the filter controls

This makes it clear that the filter widgets (tabs for "All tasks"/"Waiting for input" and the user combobox) belong to the task list below, not the prompt form above.

Before/After

The issue screenshot showed the filters appearing visually closer to the prompt than to the task list they actually control. This change adds the visual separator as suggested in the mockup.

Testing

  • ✅ All existing tests pass
  • ✅ Linting checks pass
  • ✅ TypeScript compilation successful
  • ✅ Development server verified locally

Fixes #20423

🤖 Generated with Claude Code

Add a border separator and increased padding to clearly distinguish
the task prompt form from the filter controls (tabs and user dropdown)
below it. This resolves confusion about which section the filters belong to.

Fixes #20423

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@github-actions

github-actions Bot commented Oct 22, 2025 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@bartekgatzcoder

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

cdrci2 added a commit to coder/cla that referenced this pull request Oct 22, 2025
@BrunoQuaresma

Copy link
Copy Markdown
Contributor

@bartekgatzcoder could you please add some screenshots to the description?

Comment thread site/src/pages/TasksPage/TasksPage.tsx Outdated
{permissions.viewDeploymentConfig && (
<section
className="mt-6 flex justify-between"
className="mt-6 pt-6 border-t border-border flex justify-between"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border is not doing anything, and I don't think having a border would improve anything visually. If we decide to increase the spacing between the two sections, we should only use padding for that and not both margin and padding.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look better, tho. Please see the screenshots.

This is dev.coder.com
Screenshot 2025-10-22 at 20 12 29

And this is from the workspace the Claude worked in on this ticket:
Screenshot 2025-10-22 at 20 12 21

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should only use padding for that and not both margin and padding.

big agree. the extra spacing does look a little better but bruno is also still correct about the border classes not doing anything here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added pt-8 pb-8.

PS. I'm not a tailwindcss wizard, so I'm definitely open to alternative ideas.

@johnstcn
johnstcn requested review from mtojek and removed request for buenos-nachos October 28, 2025 11:48
@mtojek
mtojek marked this pull request as draft October 29, 2025 08:33
@mtojek mtojek changed the title fix(tasks): improve visual separation between prompt and task list fix: improve visual separation between prompt and task list Oct 29, 2025
@mtojek mtojek self-assigned this Oct 29, 2025
@mtojek
mtojek marked this pull request as ready for review October 29, 2025 09:57
@mtojek

mtojek commented Oct 29, 2025

Copy link
Copy Markdown
Member

@aslilac feel free to retake a look. Thanks!

Comment thread site/src/pages/TasksPage/TasksPage.tsx Outdated
/>
{aiTemplatesQuery.isSuccess && (
<section>
<section className="pt-8 pb-8">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<section className="pt-8 pb-8">
<section className="py-8">

jsyk, there are shorthands for "padding along the y-axis on both ends" and "padding along the x-axis on both ends"

@aslilac
aslilac enabled auto-merge (squash) October 29, 2025 18:57
@aslilac
aslilac merged commit 1b6556c into main Oct 29, 2025
1 of 3 checks passed
@aslilac
aslilac deleted the fix-tasks-page-separator branch October 29, 2025 19:00
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tasks prompt and tasks list are not separated well enough

4 participants