Skip to content

chore(scripts/rules.go): ignore db imports in _test.go files - #20406

Merged
mafredri merged 1 commit into
mainfrom
mafredri/chore-scripts-rules-ignore-db-import-in-tests
Oct 22, 2025
Merged

mafredri merged 1 commit into
mainfrom
mafredri/chore-scripts-rules-ignore-db-import-in-tests

Conversation

@mafredri

Copy link
Copy Markdown
Member

This change allows us to stop adding the following for every invokation:

//nolint:gocritic // This is in a test package and does not end up in the build

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine as testing files do not end up in the built binary.

@mafredri
mafredri merged commit f64ac8f into main Oct 22, 2025

Copy link
Copy Markdown
Member Author

Merge activity

@mafredri
mafredri deleted the mafredri/chore-scripts-rules-ignore-db-import-in-tests branch October 22, 2025 09:10
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants