Repository navigation
feat: improve template version select ux - #20347
Merged
Merged
Conversation
BrunoQuaresma
requested review from
code-asher
and removed request for
a team
October 16, 2025 16:39
buenos-nachos
approved these changes
Oct 16, 2025
buenos-nachos
left a comment
buenos-nachos
left a comment
Contributor
There was a problem hiding this comment.
Code looks good! Just had a few small comments
Comment on lines
+18
to
+20
| > & { | ||
| id?: string; | ||
| }; |
Contributor
There was a problem hiding this comment.
I know this was technically here before, but why do we need this? The Trigger type should already have an optional id prop
Comment on lines
+31
to
+35
| .toSorted((a, b) => { | ||
| return ( | ||
| new Date(b.created_at).getTime() - new Date(a.created_at).getTime() | ||
| ); | ||
| }), |
Contributor
There was a problem hiding this comment.
Do we know if all of our customers can use this yet? I know toSorted broke a deployment for a customer in the past year or so because they hadn't upgraded their browser in a really long time
Contributor
Author
There was a problem hiding this comment.
It started being supported by browsers at the beginning of 2023, so I think we’re good. We don’t have a strict rule for that, but using APIs that have been available for more than two years should be safe enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements:
Demo:
Screen.Recording.2025-10-16.at.12.48.01.mov
Close coder/internal#1057