Repository navigation
fix: clear prompt after task creation - #20344
Merged
Merged
Conversation
buenos-nachos
approved these changes
Oct 16, 2025
buenos-nachos
left a comment
buenos-nachos
left a comment
Contributor
There was a problem hiding this comment.
Changes make sense to me. Just had one suggestion if we can get it to work
Comment on lines
+118
to
+121
| await step("Clears prompt", async () => { | ||
| const prompt = await canvas.findByLabelText(/prompt/i); | ||
| expect(prompt).toHaveValue(""); | ||
| }); |
Contributor
There was a problem hiding this comment.
Are we able to use a role selector here? Maybe something like:
const prompt = await canvas.findByRole("textbox", {
name: /prompt/i,
});
Contributor
Author
There was a problem hiding this comment.
I think it’s more accessible in this case to rely on the label, since that’s what both screen readers and users interact with. For example, when we get an element by role, we’re not checking whether it actually has an accessible label.
By getting an element by label, I don’t really care what type of element it is, because I can still perform the action I need.
Makes sense?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #20255