Repository navigation
feat(coderd/database): add ListTasks query - #20282
Merged
Merged
Conversation
johnstcn
force-pushed
the
cj/gh-coder-internal-981-list-tasks
branch
2 times, most recently
from
October 13, 2025 20:00
e901f8d to
7b6e819
Compare
johnstcn
force-pushed
the
cj/gh-coder-internal-981-list-tasks
branch
from
October 14, 2025 11:14
7b6e819 to
4c1b0b2
Compare
johnstcn
marked this pull request as ready for review
October 14, 2025 11:29
DanielleMaywood
approved these changes
Oct 14, 2025
DanielleMaywood
left a comment
DanielleMaywood
left a comment
Contributor
There was a problem hiding this comment.
one non-blocking and one slightly blocking question
| } | ||
|
|
||
| func (q *querier) ListTasks(ctx context.Context, arg database.ListTasksParams) ([]database.Task, error) { | ||
| // TODO(Cian): replace this with a sql filter for improved performance. |
Contributor
There was a problem hiding this comment.
non-blocking: should an issue be created for this?
Member
There was a problem hiding this comment.
Also non-blocking, this type of filter blocks pagination. But that's not critical yet.
Member
Author
There was a problem hiding this comment.
Will file a follow-up issue (EDIT: coder/internal#1061)
mafredri
approved these changes
Oct 14, 2025
| } | ||
|
|
||
| func (q *querier) ListTasks(ctx context.Context, arg database.ListTasksParams) ([]database.Task, error) { | ||
| // TODO(Cian): replace this with a sql filter for improved performance. |
Member
There was a problem hiding this comment.
Also non-blocking, this type of filter blocks pagination. But that's not critical yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to coder/internal#981
Stack: