Repository navigation
feat(coderd): add experimental tasks send endpoint - #19941
Merged
Merged
Conversation
mafredri
force-pushed
the
mafredri/feat-coderd-tasks-send
branch
2 times, most recently
from
September 24, 2025 12:46
8272a1c to
1bd075b
Compare
mafredri
force-pushed
the
mafredri/feat-coderd-tasks-send
branch
from
September 24, 2025 12:55
1bd075b to
812b2b2
Compare
mafredri
marked this pull request as ready for review
September 24, 2025 12:55
DanielleMaywood
left a comment
DanielleMaywood
left a comment
Contributor
There was a problem hiding this comment.
The logic looks fine to me, although there are a couple of stylistic nits and some unneeded use of httperror.WriteResponseWriter
DanielleMaywood
approved these changes
Sep 24, 2025
DanielleMaywood
left a comment
DanielleMaywood
left a comment
Contributor
There was a problem hiding this comment.
LGTM 
I'd feel happier with Cian having a second look as we already partly discussed the approach earlier
johnstcn
reviewed
Sep 24, 2025
mafredri
force-pushed
the
mafredri/feat-coderd-tasks-send
branch
from
September 25, 2025 09:30
20d653d to
f607b45
Compare
johnstcn
approved these changes
Sep 25, 2025
mafredri
enabled auto-merge (squash)
September 25, 2025 11:57
mafredri
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes coder/internal#902