Repository navigation
fix: force task to be created with latest version - #19923
Conversation
| return a.Name.localeCompare(b.Name); | ||
| } | ||
|
|
||
| // TODO: Enforce task creation to always use the latest active template version. |
There was a problem hiding this comment.
nit: this is rather FIXME than TODO :P
There was a problem hiding this comment.
Is FIXME a valid thing? 👀
There was a problem hiding this comment.
Yeah, we have a lot of fixmes in our codebase :)
PS. nit-pick!
| }); | ||
|
|
||
| await step("Uses latest template version", () => { | ||
| expect(API.experimental.createTask).toHaveBeenCalledWith( |
There was a problem hiding this comment.
Correct me if I'm wrong, but since this is a story not a unit test, you shouldn't assert API calls on that level?
Can we convert it to jest test instead?
There was a problem hiding this comment.
We’re using Storybook as our main testing tool. At some point, Jest will only be used for testing functions or other non-component-related code. Kayla did an awesome L&L yesterday about the FE state—I’m just trying to grab the link to share here.
| }); | ||
|
|
||
| await step("Uses latest template version", () => { | ||
| expect(API.experimental.createTask).toHaveBeenCalledWith( |
| return a.Name.localeCompare(b.Name); | ||
| } | ||
|
|
||
| // TODO: Enforce task creation to always use the latest active template version. |
There was a problem hiding this comment.
Yeah, we have a lot of fixmes in our codebase :)
PS. nit-pick!
Fixes #19744