Repository navigation
feat: display startup script logs while agent is starting - #19530
Conversation
buenos-nachos
left a comment
buenos-nachos
left a comment
There was a problem hiding this comment.
Looks good! Just had a few small suggestions
| level: "info", | ||
| output: line, | ||
| source_id: MockWorkspaceAgentLogSource.id, | ||
| created_at: new Date().toISOString(), |
There was a problem hiding this comment.
Just to be on the safe side, do we want to hard-code the date here, since new Date() would create a non-deterministic value for each story run?
| Your task will be running in a few moments | ||
| </div> | ||
| </header> | ||
| <section className="flex-1 p-16 overflow-y-auto"> |
There was a problem hiding this comment.
Is there a reason for the flex-1? I wouldn't expect a page-level component to need to worry about arbitrarily growing or shrinking
| <h3 className="m-0 font-medium text-content-primary text-xl"> | ||
| Starting your workspace | ||
| </h3> | ||
| <div className="text-content-secondary"> |
There was a problem hiding this comment.
Could we swap this div for a p?
|
|
||
| useEffect(() => { | ||
| if (listRef.current) { | ||
| listRef.current.scrollToItem(logs.length - 1, "end"); |
There was a problem hiding this comment.
Do you know what the scroll behavior is for the React Window component? As in, do you know if the scroll is instant, or if it does an animation?
Because if it's instant, we could swap in useLayoutEffect to reduce any risk of screen flickering
There was a problem hiding this comment.
It is instant, and we can move to use useLayoutEffect for sure.
| <h3 className="m-0 font-medium text-content-primary text-xl"> | ||
| Running startup scripts | ||
| </h3> | ||
| <div className="text-content-secondary"> |
There was a problem hiding this comment.
Think we could use a p here, too
Closes #19363
Screenshot:
Demo:
Screen.Recording.2025-08-22.at.16.00.23.mov