Repository navigation
feat: show workspace build logs during tasks creation - #19413
Conversation
BrunoQuaresma
changed the title
|
Should we collapse/hide these by default and only show if a user clicks on show build logs? I think for most Tasks users they may not be interested in seeing the build logs. |
johnstcn
left a comment
johnstcn
left a comment
There was a problem hiding this comment.
Could you add some stories for the following scenarios:
- Workspace build pending
- Workspace build running
- Workspace build failed
|
@matifali I would agree with you if the screen had more info. Display the build logs is a way to show to the user that things are in progress. Before make any changes to it, I would like to test this hypothesis and see what users think about that, wdyt? |
|
@johnstcn they are already there. |
|
@BrunoQuaresma, I am fine if we want to test this. What I was thinking is a loading animation of some kind (Spinner) and a button to view logs if needed. |
johnstcn
left a comment
johnstcn
left a comment
There was a problem hiding this comment.
Sorry, missed seeing the stories! UI changes LGTM but also need approval from FE domain expert.
| return ( | ||
| <> | ||
| <Helmet> | ||
| <title>{pageTitle(ellipsizeText(task.prompt, 64) ?? "Task")}</title> |
There was a problem hiding this comment.
| <title>{pageTitle(ellipsizeText(task.prompt, 64) ?? "Task")}</title> | |
| <title>{pageTitle(ellipsizeText(task.prompt, 64) || task.workspace.name)}</title> |
...might be nice as a still safe but more descriptive fallback. also maybe || incase prompt is ""? I think you said that's not possible, but if it isn't I'm kinda confused on why we need the fallback at all
There was a problem hiding this comment.
Good catch. I'm going to remove this fallback too 👍
|
|
||
| export default TaskPage; | ||
|
|
||
| const TaskBuildingWorkspace: FC<{ task: Task }> = ({ task }) => { |
There was a problem hiding this comment.
| const TaskBuildingWorkspace: FC<{ task: Task }> = ({ task }) => { | |
| type TaskBuildingWorkspaceProps = { | |
| task: Task; | |
| }; | |
| const TaskBuildingWorkspace: FC<TaskBuildingWorkspaceProps> = ({ task }) => { |
| import { Link as RouterLink } from "react-router"; | ||
| import { TaskStatusLink } from "./TaskStatusLink"; | ||
|
|
||
| export const TaskTopbar: FC<{ task: Task }> = ({ task }) => { |
There was a problem hiding this comment.
same here, give this type a name pls
| </TooltipProvider> | ||
|
|
||
| <h1 className="m-0 text-base font-medium truncate"> | ||
| {task.prompt || task.workspace.name} |
There was a problem hiding this comment.
re: fallbacks
this stands out to me too
| dayjs.extend(duration); | ||
|
|
||
| // ActiveTransition gets the build estimate for the workspace, | ||
| // getActiveTransitionStats gets the build estimate for the workspace, |
This is part of #19363
Screenshot:
Video demo:
Screen.Recording.2025-08-19.at.12.32.15.mov