Repository navigation
fix(site): fix render crash when no embedded apps are defined for task - #19215
Merged
Merged
Conversation
DanielleMaywood
force-pushed
the
danielle/tasks/fix-no-apps-crash
branch
from
August 7, 2025 09:31
6fdaa27 to
26b5f2c
Compare
DanielleMaywood
marked this pull request as ready for review
August 7, 2025 09:42
johnstcn
reviewed
Aug 7, 2025
johnstcn
left a comment
johnstcn
left a comment
Member
There was a problem hiding this comment.
LGTM but deferring approval to Bruno
BrunoQuaresma
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19101
We now gracefully handle the scenario when there are no embedded apps defined for a task.
I've added a storybook file specifically for the
TaskAppscomponent. I'm aware we already have some stories forTaskAppsin theTaskPage.stories.tsxso I'm happy to move these stories over to that if it makes more sense.