Repository navigation
chore(coderd/provisionerdserver): remove dangerous usage of dbtestutil.DisableForeignKeysAndTriggers - #19122
Merged
johnstcn merged 1 commit intoAug 4, 2025
Conversation
…l.DisableForeignKeysAndTriggers
spikecurtis
approved these changes
Aug 4, 2025
Emyrk
approved these changes
Aug 4, 2025
Emyrk
left a comment
Emyrk
left a comment
Member
There was a problem hiding this comment.
Nice! Ideally we remove this everywhere incrementally. Maybe we should add a linter to catch new additions?
johnstcn
deleted the
cj/chore/provisionerdserver-no-disable-foreign-key-checks
branch
August 4, 2025 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May have caught #18776