Repository navigation
feat: add preset selector in TasksPage - #19012
Conversation
0a11e8e to
ebeb601
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a preset selector to the TasksPage that appears when the selected template version has defined presets. If a preset contains an AI Prompt parameter, it overrides the textarea input and makes it read-only.
- Adds preset selection functionality with automatic default preset selection
- Implements AI prompt override behavior when presets contain AI Prompt parameters
- Refactors test data by moving mock objects to shared test helpers for better reusability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| site/src/testHelpers/entities.ts | Adds mock preset data and task data for testing preset functionality |
| site/src/pages/TasksPage/TasksPage.tsx | Implements preset selector UI, preset fetching logic, and AI prompt override behavior |
| site/src/pages/TasksPage/TasksPage.stories.tsx | Updates stories to use shared mock data and adds new stories for preset scenarios |
There was a problem hiding this comment.
The template and preset selectors use identical styling (w-80 text-xs [&_svg]:size-icon-xs border-0 bg-surface-secondary h-8 px-3). Consider extracting this into a CSS class or constant to avoid duplication.
| className="w-80 text-xs [&_svg]:size-icon-xs border-0 bg-surface-secondary h-8 px-3" | |
| className="select-trigger-style" |
There was a problem hiding this comment.
review: moved to entities.ts
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
I don't feel super comfortable with extra useEffects, but I assume that we need to reload it dynamically, right?
There was a problem hiding this comment.
nit: maybe extract to a seperate function with a comment?
There was a problem hiding this comment.
nit: is it special/magic parameter now?
|
Is selecting a preset required? On the create workspace page I added a "None" to make it explicit that choosing a preset is not necessary. |
Right now it technically isn't, although presets are currently the only way to expose parameter values on Tasks page. I can add a "none" option for consistency. |
There was a problem hiding this comment.
Maybe this could be done later but it can be confusing for users that the Prompt is disabled because of a preset. In the dynamic parameters create workspace page, I label parameters when they are preset as such so user know why they can't be edited.
There was a problem hiding this comment.
I could add a quick tooltip here
f6ecc40 to
b3916e2
Compare
that is visible if the selected template version defines presets,with the default preset pre-selected and at the top of the list.