Repository navigation
chore: run make clean on workspace startup - #16660
Merged
Merged
Conversation
aslilac
changed the title
make clean on workspace shutdownmake clean on workspace startup
aslilac
marked this pull request as ready for review
February 21, 2025 22:20
matifali
reviewed
Feb 22, 2025
matifali
left a comment
matifali
left a comment
Member
There was a problem hiding this comment.
Can we move this to a coder_script with run_on_stop = true.
Member
Author
|
in my testing, can we fix |
matifali
approved these changes
Feb 24, 2025
Member
|
@aslilac can you create an issue with your experience with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally thought using
shutdown_scriptwould be better, but after some testing it seems likeshutdown_scripts don't get run nearly as consistently. Idk what's going on there, but running this on startup shouldn't be too bad because it should always be fast, at least.Our various build outputs can easily take up dozens of gigabytes per workspace. Multiply that across dozens of engineers, and it's considerable. We've been seeing a lot of disk utilization warnings lately because some of our disks are getting "too" full (even though in reality they often have hundreds of gigabytes of spare capacity). This is an easy way to quiet those warnings, and leave us with plenty of capacity to onboard additional engineers without needing to upgrade our actual storage resources.
Also bumps threshold to 90%, because realistically that's still a ton of spare capacity.