Repository navigation
chore: update semantic types - #1030
Merged
Merged
Conversation
Summary: PRs like #1025 feel like they deserve a doc: type, but we didn't have one. Furthermore our definitions for correct and fix were stale.
greyscaled
commented
Apr 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #1030 +/- ##
==========================================
+ Coverage 57.70% 67.37% +9.66%
==========================================
Files 259 259
Lines 15059 15059
Branches 151 151
==========================================
+ Hits 8690 10146 +1456
+ Misses 5426 3893 -1533
- Partials 943 1020 +77
Continue to review full report at Codecov.
|
kylecarbs
reviewed
Apr 15, 2022
kylecarbs
left a comment
kylecarbs
left a comment
Member
There was a problem hiding this comment.
I'd prefer we make an example tag for now. It'd be cool to see the delta of example changes between releases anyways!
Contributor
Author
sounds great to me! |
greyscaled
commented
Apr 15, 2022
greyscaled
commented
Apr 15, 2022
greyscaled
requested review from
a team,
Emyrk,
coadler,
deansheather,
f0ssel,
johnstcn and
kylecarbs
and removed request for
Emyrk,
coadler,
deansheather,
f0ssel and
johnstcn
April 15, 2022 18:48
greyscaled
commented
Apr 15, 2022
johnstcn
approved these changes
Apr 15, 2022
presleyp
approved these changes
Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
PRs like #1025 feel like they deserve an
example:type, but we didn't have one.Furthermore our definitions for correct, fix, and hotfix were stale.