Skip to content

Web terminal does not re-connect when agent is restarted (spot VM) #5292

Closed

Description

@bpmct

Summary from @kylecarbs:

  1. When an agent disconnects, we can't close all Coder server -> workspace connections because it could be intermittent. e.g. if you have multiple Coder replicas, one shuts off due to an upgrade but that was where the agent was connected, we don't want to lose all other client connections.
  2. The agent should have an "instance ID" associated with itself to identify when a new instance popped up. When it does, we should publish to all replicas to close connections that are for the old identifier.

Activity

  1. bpmct commented on Dec 5, 2022

    @bpmct
    MemberAuthor

    I also ran into this with a template that creates workspaces as Kubernetes deployments, and then I deleted the pod. It re-created and the agent connected, but the web terminal never connected. I was able to connect over SSH okay. Agent logs

  2. bpmct commented on Jan 25, 2023

    @bpmct
    MemberAuthor

    I'm also noticing this when I run sudo reboot on an AWS VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions