docs: Update some more links by im-coder-lg · Pull Request #4806 · coder/code-server

im-coder-lg · 2022-01-29T03:27:38Z

I will try checking the docs too, that might be easier here :)

Fixes #4802
Don't merge this right now, I'll update the documentation. Sorry for the ping @jawnsy but you only can help me with this - docs preview maybe locally or on the cloud. @jsjoeio I'll inform you once the PR is ready, should I do rebasing and FMTs if more commits are added to the HEAD branch?
Again, sorry for the pings, I want to finish this soon.

I will try checking the docs too

codecov · 2022-01-29T03:38:36Z

Codecov Report

Merging #4806 (1d268b4) into main (439f27c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4806   +/-   ##
=======================================
  Coverage   69.18%   69.18%           
=======================================
  Files          29       29           
  Lines        1652     1652           
  Branches      363      363           
=======================================
  Hits         1143     1143           
  Misses        432      432           
  Partials       77       77

Impacted Files	Coverage Δ
src/node/cli.ts	`83.58% <ø> (ø)`
src/node/coder_cloud.ts	`27.27% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439f27c...1d268b4. Read the comment docs.

im-coder-lg · 2022-01-29T04:15:55Z

Hey, one small doubt - now I edited the package.json and GitHub triggered an action(NPM). Does that mean the base branch's package.json gets overruled? Meaning, does the NPM registry show the new links?

im-coder-lg · 2022-01-30T13:40:37Z

I just had a chat with @bpmct on Slack - there are a lot of files that got updated. Hope it doesn't meddle with builds.

im-coder-lg · 2022-01-31T01:51:09Z

/ping @jsjoeio please let me know if I have to change anything.

im-coder-lg · 2022-01-31T15:39:58Z

/ping @jsjoeio I think the PR is ready for review.

im-coder-lg · 2022-01-31T15:41:07Z

Also, a question - does FMT mean formatting? Like Prettier code formatting?

jsjoeio · 2022-01-31T20:28:31Z

@im-coder-lg thanks for doing this! Yes, ideally you run yarn fmt to fix the formatting then commit and push up. Should be good after that.

jsjoeio

Most of it is good but some places we're accidentally wrote "coderer"

Let's fix those and then we'll be good 👍

jsjoeio · 2022-01-31T20:29:20Z

docs/CONTRIBUTING.md

 ## Creating pull requests

-Please create a [GitHub Issue](https://github.com/cdr/code-server/issues) that
+Please create a [GitHub Issue](https://github.com/coderer/code-server/issues) that


Suggested change

Please create a [GitHub Issue](https://github.com/coderer/code-server/issues) that

Please create a [GitHub Issue](https://github.com/coder/code-server/issues) that

Never saw those coming! I'll fix it.

jsjoeio · 2022-01-31T20:29:30Z

docs/CONTRIBUTING.md

 ## Development workflow

-The current development workflow is a bit tricky because we have this repo and we use our `cdr/vscode` fork inside it with [`yarn link`](https://classic.yarnpkg.com/lang/en/docs/cli/link/).
+The current development workflow is a bit tricky because we have this repo and we use our `coderer/vscode` fork inside it with [`yarn link`](https://classic.yarnpkg.com/lang/en/docs/cli/link/).


Suggested change

The current development workflow is a bit tricky because we have this repo and we use our `coderer/vscode` fork inside it with [`yarn link`](https://classic.yarnpkg.com/lang/en/docs/cli/link/).

The current development workflow is a bit tricky because we have this repo and we use our `coder/vscode` fork inside it with [`yarn link`](https://classic.yarnpkg.com/lang/en/docs/cli/link/).

jsjoeio · 2022-01-31T20:29:43Z

docs/FAQ.md

 whatever amount of time you'd like), you can kill code-server.

-Eventually, [#1636](https://github.com/cdr/code-server/issues/1636) will make
+Eventually, [#1636](https://github.com/coderer/code-server/issues/1636) will make


Can we fix this file too?

Done, I'll commit soon.

jsjoeio · 2022-01-31T20:29:53Z

docs/guide.md

 You must use `/absproxy/<port>` with `create-react-app` (see
-[#2565](https://github.com/cdr/code-server/issues/2565) and
-[#2222](https://github.com/cdr/code-server/issues/2222) for more information).
+[#2565](https://github.com/coderer/code-server/issues/2565) and


and this one

jsjoeio · 2022-01-31T20:29:58Z

docs/helm.md

 [![Version: 1.0.0](https://img.shields.io/badge/Version-1.0.0-informational?style=flat-square)](https://img.shields.io/badge/Version-1.0.0-informational?style=flat-square) [![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)](https://img.shields.io/badge/Type-application-informational?style=flat-square) [![AppVersion: 4.0.2](https://img.shields.io/badge/AppVersion-4.0.2-informational?style=flat-square)](https://img.shields.io/badge/AppVersion-4.0.2-informational?style=flat-square)

-[code-server](https://github.com/cdr/code-server) code-server is VS Code running
+[code-server](https://github.com/coderer/code-server) code-server is VS Code running


and this one

jsjoeio · 2022-01-31T20:30:07Z

docs/ipad.md

 - Keyboard issues:
  - The keyboard disappear sometimes
-    [#979](https://github.com/cdr/code-server/issues/979)
+    [#979](https://github.com/coderer/code-server/issues/979)


and this one

jsjoeio · 2022-01-31T20:30:19Z

docs/npm.md


 Using other versions of Node.js [may lead to unexpected
-behavior](https://github.com/cdr/code-server/issues/1633).
+behavior](https://github.com/coderer/code-server/issues/1633).


jsjoeio · 2022-01-31T20:30:25Z

docs/triage.md

 1. If more information is required, please ask the submitter and tag as
   `waiting-for-info` and wait.
 1. Finally, the issue should be moved into the
-   [code-server](https://github.com/cdr/code-server/projects/1) project where we


jsjoeio · 2022-01-31T20:30:31Z

package.json

+    "url": "https://github.com/coderer/code-server/issues"
  },
-  "repository": "https://github.com/cdr/code-server",
+  "repository": "https://github.com/coderer/code-server",


and this one

im-coder-lg · 2022-02-01T00:40:42Z

My god, a lot of coderers, I'll fix this.

im-coder-lg · 2022-02-01T00:49:37Z

I'll change that when I boot my PC. My phone's doing some black magic, it's posting gibberish when I try editing. This will be done by 6:45 AM IST.

im-coder-lg · 2022-02-01T02:38:38Z

Committing! @jsjoeio I think everythiong's fixed now.

I should've used all three toggles in the Search/Replace tab in the GItHub.dev editor.

im-coder-lg · 2022-02-01T02:40:42Z

From now, I better be careful with the Find/Replace feature, if I enabled all three toggles, this wouldn't have happened.

im-coder-lg · 2022-02-01T02:52:31Z

I committed the formatted code. Tried rebasing but everything seemed to be up-to-date, so I did formatting twice, to confirm.

jsjoeio

im-coder-lg · 2022-02-02T10:41:10Z

Love that GIF, that's what I would want to do. Thanks for the opportunity!

@bpmct

* Update links in package.json I will try checking the docs too * docs: Update links in triage.md * docs: Update links in npm.md * docs: Update links in whatever files that have `cdr` * Replace globally, thanks @bpmct! * fix: coderer instead of coder I should've used all three toggles in the Search/Replace tab in the GItHub.dev editor. * Code Formatting

Update links in package.json

dfeca1c

I will try checking the docs too

im-coder-lg requested a review from a team January 29, 2022 03:27

docs: Update links in triage.md

7b4248e

im-coder-lg added 2 commits January 29, 2022 09:08

docs: Update links in npm.md

37435de

docs: Update links in whatever files that have cdr

97d864d

im-coder-lg changed the title ~~Fix more links~~ docs: Update some more links Jan 29, 2022

Replace globally, thanks @bpmct!

72e6d5f

jsjoeio self-assigned this Jan 31, 2022

jsjoeio added this to the 4.0.3 milestone Jan 31, 2022

jsjoeio suggested changes Jan 31, 2022

View reviewed changes

fix: coderer instead of coder

4b1c556

I should've used all three toggles in the Search/Replace tab in the GItHub.dev editor.

Code Formatting

1d268b4

jsjoeio approved these changes Feb 1, 2022

View reviewed changes

jsjoeio merged commit 10f57ba into coder:main Feb 1, 2022

	Please create a [GitHub Issue](https://github.com/coderer/code-server/issues) that
	Please create a [GitHub Issue](https://github.com/coder/code-server/issues) that

	The current development workflow is a bit tricky because we have this repo and we use our `coderer/vscode` fork inside it with [`yarn link`](https://classic.yarnpkg.com/lang/en/docs/cli/link/).
	The current development workflow is a bit tricky because we have this repo and we use our `coder/vscode` fork inside it with [`yarn link`](https://classic.yarnpkg.com/lang/en/docs/cli/link/).

Conversation

im-coder-lg commented Jan 29, 2022

Uh oh!

codecov bot commented Jan 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

im-coder-lg commented Jan 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

im-coder-lg commented Jan 30, 2022

Uh oh!

im-coder-lg commented Jan 31, 2022

Uh oh!

im-coder-lg commented Jan 31, 2022

Uh oh!

im-coder-lg commented Jan 31, 2022

Uh oh!

jsjoeio commented Jan 31, 2022

Uh oh!

jsjoeio left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

im-coder-lg commented Feb 1, 2022

Uh oh!

im-coder-lg commented Feb 1, 2022

Uh oh!

im-coder-lg commented Feb 1, 2022

Uh oh!

im-coder-lg commented Feb 1, 2022

Uh oh!

im-coder-lg commented Feb 1, 2022

Uh oh!

jsjoeio left a comment

Choose a reason for hiding this comment

Uh oh!

im-coder-lg commented Feb 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jan 29, 2022 •

edited

Loading

im-coder-lg commented Jan 29, 2022 •

edited

Loading