Conversation
|
✨ Coder.com for PR #4797 deployed! It will be updated on every commit.
|
jsjoeio
force-pushed
the
jsjoeio-fix-npm-workflows
branch
from
91fc1cc to
ea161c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #4797 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 29 29
Lines 1652 1652
Branches 363 363
=======================================
Hits 1143 1143
Misses 432 432
Partials 77 77 Continue to review full report at Codecov.
|
jsjoeio
commented
Jan 27, 2022
jsjoeio
force-pushed
the
jsjoeio-fix-npm-workflows
branch
from
c7773f4 to
24c4b27
Compare
This refactors the npm workflows to use the download-artifact GitHub Action. We had problems in the past with our download_artifact custom bash function. This also fixes an issue where we weren't downloading the correct artifacts when publishing beta and dev tags to npm.
jsjoeio
force-pushed
the
jsjoeio-fix-npm-workflows
branch
from
24c4b27 to
eed8d58
Compare
Contributor
Author
|
@code-asher this is good to go now! |
code-asher
requested changes
Feb 1, 2022
Member
code-asher
left a comment
code-asher
left a comment
There was a problem hiding this comment.
Looking really good! I am stoked about beginning the move to the download action.
Contributor
Author
|
Transitioning back to draft to address changes |
code-asher
approved these changes
Feb 3, 2022
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
* feat: refactor npm workflows to use download-artifact This refactors the npm workflows to use the download-artifact GitHub Action. We had problems in the past with our download_artifact custom bash function. This also fixes an issue where we weren't downloading the correct artifacts when publishing beta and dev tags to npm. * fixup: remove unused env var * fixup! add download-artifcat to npm-brew" * fixup! remove unnecessary code comment * fixup! move NPM_ENVIRONMENT logic to script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a couple issues with the npm workflows, mainly ensuring that we download the correct npm artifact before uploading to npm.
download-artifactactionFixes #4790