fix: package bin/helper directory in the right spot#4776
Merged
code-asher merged 1 commit intocoder:mainfrom Jan 21, 2022
Merged
fix: package bin/helper directory in the right spot#4776code-asher merged 1 commit intocoder:mainfrom
code-asher merged 1 commit intocoder:mainfrom
Conversation
VS Code moves this as part of their packaging task. We will probably want to look into using theirs instead of replicating it. Fixes coder#4721
code-asher
changed the title
Codecov Report
@@ Coverage Diff @@
## main #4776 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 29 29
Lines 1652 1652
Branches 363 363
=======================================
Hits 1143 1143
Misses 432 432
Partials 77 77 Continue to review full report at Codecov.
|
jsjoeio
approved these changes
Jan 20, 2022
Contributor
jsjoeio
left a comment
jsjoeio
left a comment
There was a problem hiding this comment.
That is unusual they change the path in production 🤔 I guess we'll have to investigate later. Thanks for fixing this!
Member
Author
|
Happens here btw: And here is the build step: |
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
VS Code moves this as part of their packaging task. We will probably want to look into using theirs instead of replicating it. Fixes coder#4721
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VS Code moves this as part of their packaging task. We will probably
want to look into using theirs instead of replicating it.
Fixes #4721