Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4770 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 29 29
Lines 1652 1652
Branches 363 363
=======================================
Hits 1143 1143
Misses 432 432
Partials 77 77 Continue to review full report at Codecov.
|
Contributor
Author
|
Also, an unrelated question - how did you enable Codecov? |
jsjoeio
approved these changes
Jan 20, 2022
Contributor
jsjoeio
left a comment
jsjoeio
left a comment
There was a problem hiding this comment.
Thank you for doing this!
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
* docs: Change `cdr` to `coder`, read desc please Yeah, includes links. * docs: Update README (links and the extra comma) Co-authored-by: Joe Previte <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Minor fix
@jsjoeio I have applied the changes(
cdrtocoder) to the links, user(in this case, org) and removed the extra comma in the README(code-server or Coder difference) that made me think it's not right.This is ready for merge, however, should I run
yarn fmtand rebase(before FMT of course) again?