Codecov Report

Merging #3437 (445618d) into main (ac96517) will not change coverage.
The diff coverage is n/a.

❗ Current head 445618d differs from pull request most recent head 3a426e4. Consider uploading reports for the commit 3a426e4 to get more accurate results

@@           Coverage Diff           @@
##             main    #3437   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          35       35           
  Lines        1709     1709           
  Branches      379      379           
=======================================
  Hits         1012     1012           
  Misses        559      559           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac96517...3a426e4. Read the comment docs.

Notes

Looking at the vs_code_welcome_page.ts, there is a line which should be mac-only which opens a folder by executing the command workbench.action.files.openFileFolder.

When the link gets called, the commandService is used. First, it uses the id workbench.action.files.openFileFolder to look up the command in the CommandsRegistry. If the command isn't found, it rejects the promise. The question is: why isn't it found?

We need to find the list of commands and see what's there 🤔

From what I can tell, actions are "registered" like registerAction2(KeybindingsReferenceAction);

Funny enough, I can't tell how the OpenFileFolderAction gets registered 🤔
Here is the code upstream.

Okay I found this issue. If you look here I found the issue I believe! If you look here, that action only), they only use the OpenFileFolderAction on mac desktop (not web). So we need to change the action in the Welcome Page to use the OpenFolder and it should work.

This change happened on April 21 in the 1.56.2 release: microsoft/vscode@141ecfb#diff-c294b7c700c8aaaac2bce37dd95450e3ab232e0e52fcc181b7c94780f01aa17a

This PR fixes the "Open Folder" link on the Welcome page.

Changes

• update Welcome Page to use openFolder

Screenshots

Screen.Recording.2021-05-21.at.12.00.08.PM.mov

Checklist

• tested locally
• updated CHANGELOG.md

Fixes #2921

Related:

• Can't open folder - Command 'workbench.action.files.openFileFolder' not found #3427
• "open folder" link in Welcome screen doesn't work in 3.10.1 #3436

Which theme did you use @jsjoeio , that looks pretty awesome!

Thanks @nooobcoder ! It's this one: https://open-vsx.org/extension/max-SS/Cyberpunk