add Csdms mapping #371

hsu000001 · 2024-12-20T21:03:58Z

Please see new mapping to csdms.csv

Indicated multiple fields relevant with semicolons.

Did not yet run aggregate.py

progval · 2024-12-20T22:36:55Z

Should this PR replace #370?

Do you have a link to definitions of csdms terms?

Indicated multiple fields relevant with semicolons.

Could you use a slash surrounded with spaces, instead?

hsu000001 · 2024-12-21T02:40:57Z

Hi, #370 and #371 are for two different systems

I will get with csdms folks to find definitions.

I will update both this csdms.csv mapping, and the usgs-modelcat.csv mapping the the / for multiple items.

hsu000001 · 2024-12-21T02:48:16Z

Now that multiple fields are indicated by " / ", there is one row where the field itself in csdms contains that string, it is on line 54, affiliation,Institute / Organization

where in csdms, the field is "Institute / Organization", but let me check with @kettner

Also, @kettner, "Do you have a link to definitions of csdms terms?" (Nevermind, web search did the trick)
CSDMS terms definitions: https://csdms.colorado.edu/wiki/Available_model_questionnaire_conditions

progval · 2024-12-20T22:38:15Z

crosswalks/csdms.csv

@@ -0,0 +1,74 @@
+Property,csdms
+codeRepository,Source web address


I'm not sure this is a good match. codeRepository should be the URL of a VCS, not of a website. On Github, https://github.com/codemeta/codemeta can serve as both (though https://github.com/codemeta/codemeta.git would be the canonical repository URL), but this not true everywhere.

Source web address's definition on https://csdms.colorado.edu/wiki/Available_model_questionnaire_conditions kind of matches codeRepository's definition, but the examples show that in practice the name trumps the definition, as all examples point to a webpage instead of a code repository.

We would prefer to move in the correct direction and start using Source web address according to its definition, and keep the mapping. But if you prefer that we remove the mapping due to practice, let us know.

I'm fine with it either way, but you should fix it on your side in order to avoid incorrect translations.

OK, we will keep this mapping and work to align.

crosswalks/csdms.csv

progval · 2024-12-21T07:20:59Z

crosswalks/csdms.csv

+review,
+runtimePlatform,
+targetProduct,
+applicationCategory,module_type


I don't see it on https://csdms.colorado.edu/wiki/Available_model_questionnaire_conditions

If it is not on the URL you mentioned, it are not available for query.
However it exists in the schema. See screenshot

We went to check and module_type is on the list, example: https://csdms.colorado.edu/wiki/Property:Model_type , we think this is the correct mapping.

This seems to be how the application is structured, rather than what people use the application for like the examples given on https://schema.org/applicationCategory ("Game, Multimedia"). But I don't know what https://schema.org/applicationCategory is used for, so probably not a big deal

I think application category is more for defining domain-specific terms for findability. It could be similar to what in CSDMS you call "Domain" (Terrestial, Hydrology, etc.)

We propose that there is a default value here that would apply to all of CSDMS that would be the string "Scientific Model" or "Scientific Tool" - how would I indicate that in the mapping?

crosswalks/csdms.csv

match wording of actual field, not Human readable phrase Co-authored-by: Val Lorentz <[email protected]>

use field name, not human-readable text from questionnaire Co-authored-by: Val Lorentz <[email protected]>

match actual field name Co-authored-by: Val Lorentz <[email protected]>

use just the field that maps well Co-authored-by: Val Lorentz <[email protected]>

remove second Source web address mapping Co-authored-by: Val Lorentz <[email protected]>

hsu000001 · 2025-01-17T15:49:33Z

We resolved or responded to all issues and think this mapping is now complete. Look forward to next step.

hsu000001 · 2025-02-14T17:15:49Z

Hello, just checking on this PR, thanks.

progval

There are still several comments that you did not address. Github shows them as "11 hidden conversations", that you need to click

Co-authored-by: Val Lorentz <[email protected]>

confirmed field name Co-authored-by: Val Lorentz <[email protected]>

hsu000001 · 2025-05-22T17:45:30Z

Discussed today: CSDMS has a CodeReviewed field, which is a yes/no, and indicates if the model was reviewed in JOSS. This does not seem to fit in any of the existing fields as specified. How might this be implemented, the URL/DOI of the JOSS paper? But there is not currently a field for that in CSDMS I do not think, so just logging this as an idea. Don't think it should be mapped right now. @kettner, @igarousi

hsu000001 · 2025-05-22T17:57:24Z

"isAccessibleForFree" should be a default "True" for all entries in CSDMS - not sure how to indicate that in the mapping.

progval · 2025-05-22T18:39:46Z

CSDMS has a CodeReviewed field, which is a yes/no, and indicates if the model was reviewed in JOSS. This does not seem to fit in any of the existing fields as specified. How might this be implemented, the URL/DOI of the JOSS paper? But there is not currently a field for that in CSDMS I do not think, so just logging this as an idea. Don't think it should be mapped right now.

Indeed.

"isAccessibleForFree" should be a default "True" for all entries in CSDMS - not sure how to indicate that in the mapping.

There is no way to express that in crosswalks

moranegg · 2025-08-06T15:34:58Z

Let's get this in as is and improve with SSSOM methodology.

tmorrell

Looks good to go as is, and additional improvements can be made in the future.

moranegg · 2025-09-24T09:17:18Z

There is one failing check to resolve before merging.
@hsu000001 thank you for your patience. Can you check to resolve so we can merge before the v3.1 release (planned for the end of September)

hsu000001 · 2025-09-26T19:00:09Z

There is one failing check to resolve before merging. @hsu000001 thank you for your patience. Can you check to resolve so we can merge before the v3.1 release (planned for the end of September)

I seem to have waited too long, when I look for the details of the 1 failing check, it says "The logs for this run have expired and are no longer available."

Any advice to figure out what is causing it to fail? Thanks.

progval · 2025-09-29T11:18:06Z

You can get the error by running python3 scripts/aggregate.py on your computer

Add hsu000001 from PR codemeta#371 (csdms)

hsu000001 added 4 commits January 12, 2024 15:30

crosswalk usgs-modelcat

f077d5d

removed quotes

db6ad7e

Merge branch 'codemeta:master' into master

6a9171f

initial csdms mapping

c471c37

hsu000001 mentioned this pull request Dec 20, 2024

review csdms mapping hsu000001/codemeta#1

Closed

delimit multiple with slash

c3a3896

progval reviewed Dec 21, 2024

View reviewed changes

progval mentioned this pull request Dec 21, 2024

add Usgsmodelcat mapping #370

Merged

hsu000001 and others added 7 commits January 10, 2025 10:26

Update crosswalks/csdms.csv

9481309

match wording of actual field, not Human readable phrase Co-authored-by: Val Lorentz <[email protected]>

Update crosswalks/csdms.csv

bcafc32

use field name, not human-readable text from questionnaire Co-authored-by: Val Lorentz <[email protected]>

Update crosswalks/csdms.csv

03aa387

match actual field name Co-authored-by: Val Lorentz <[email protected]>

Update crosswalks/csdms.csv

85f12ea

use just the field that maps well Co-authored-by: Val Lorentz <[email protected]>

suggestions from progval

156b14a

Merge branch 'csdms' of https://github.com/hsu000001/codemeta into csdms

91cfbba

Update crosswalks/csdms.csv

d464a28

remove second Source web address mapping Co-authored-by: Val Lorentz <[email protected]>

progval approved these changes Feb 14, 2025

View reviewed changes

progval requested changes Feb 14, 2025

View reviewed changes

moranegg added the non-breaking This label should be used on changes that are non-breaking label May 9, 2025

moranegg added this to the v3.1 milestone May 9, 2025

hsu000001 and others added 5 commits May 22, 2025 10:49

Update crosswalks/csdms.csv

aa9c1cf

Co-authored-by: Val Lorentz <[email protected]>

Update crosswalks/csdms.csv

b6dd016

Co-authored-by: Val Lorentz <[email protected]>

Update crosswalks/csdms.csv

3e7fba1

Co-authored-by: Val Lorentz <[email protected]>

Update crosswalks/csdms.csv

173553c

Co-authored-by: Val Lorentz <[email protected]>

Update crosswalks/csdms.csv

de5409b

confirmed field name Co-authored-by: Val Lorentz <[email protected]>

updates to hidden comments

0e2a07a

tmorrell approved these changes Aug 6, 2025

View reviewed changes

progval approved these changes Aug 8, 2025

View reviewed changes

Add missing property embargoEndDate

b486021

progval merged commit 64e0682 into codemeta:master Sep 30, 2025
3 checks passed

bact added a commit to bact/codemeta that referenced this pull request Oct 7, 2025

Update Contributors (add hsu000001)

da8bce9

Add hsu000001 from PR codemeta#371 (csdms)

bact mentioned this pull request Oct 7, 2025

Update Contributors (add hsu000001) #430

Merged

		@@ -0,0 +1,74 @@
		Property,csdms
		codeRepository,Source web address

add Csdms mapping #371

add Csdms mapping #371

Uh oh!

Conversation

hsu000001 commented Dec 20, 2024

Uh oh!

progval commented Dec 20, 2024

Uh oh!

hsu000001 commented Dec 21, 2024

Uh oh!

hsu000001 commented Dec 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

progval Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hsu000001 commented Jan 17, 2025

Uh oh!

hsu000001 commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

progval left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hsu000001 commented May 22, 2025

Uh oh!

hsu000001 commented May 22, 2025

Uh oh!

progval commented May 22, 2025

Uh oh!

moranegg commented Aug 6, 2025

Uh oh!

tmorrell left a comment

Choose a reason for hiding this comment

Uh oh!

moranegg commented Sep 24, 2025

Uh oh!

hsu000001 commented Sep 26, 2025

Uh oh!

progval commented Sep 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hsu000001 commented Dec 21, 2024 •

edited

Loading

progval Dec 20, 2024 •

edited

Loading

hsu000001 commented Feb 14, 2025 •

edited

Loading

progval left a comment •

edited

Loading