Skip to content

Conversation

@bact
Copy link
Contributor

@bact bact commented Jan 9, 2024

  • Update crosswalk CSV files to have equal number of properties, so the scripts/aggregate.py can properly generate every properties (73 properties) (currently it will produce only 70, omitting the last three properties)

    • Add [ readme, hasSourceCode, isSourceCodeOf ] properties to Citation File Format 1.2.0.csv
    • Remove all lines with only one comma at the end of CSVs
  • Update SciCrunchRegistry.csv

    • Line 21-74: Remove Unicode Character 'NO-BREAK SPACE' (U+00A0)
  • Update ISO_19115-1.csv

    • Line 1: Add missing 2nd column header name
    • Line 23-24: Remove a leading space from the 2nd field
    • Line 37: Use ' instead of `, around pointOfContact, to be consistent with other rows

- Update crosswalk CSV files to have equal number of rows, so the `scripts/aggregate.py` can properly generate every rows (73 rows) (currently it will produce only 70, omitting the last three properties)
  - Add [ readme, hasSourceCode, isSourceCodeOf ] properties to `Citation File Format 1.2.0.csv`
  - Remove all lines with only one comma at the end of CSVs

`SciCrunchRegistry.csv`
- Line 21-74: Remove Unicode Character 'NO-BREAK SPACE' (U+00A0)

`ISO_19115-1.csv`
- Line 1: Add missing 2nd column header name
- Line 23-24: Remove a leading space from the 2nd field
- Line 37: Change `role=`pointOfContact`` to `role='pointOfContact'` (use `'` instead of ```, to be consistent with other rows)
@bact
Copy link
Contributor Author

bact commented Jan 9, 2024

Btw, I have made no changes to newline characters (\r\n \n) but Git reports changes in Cargo.csv, Citation File Format 1.2.0.csv, and Julia Project.csv at Line 4 and 58-62 (same line numbers for all 3 files) and Line 72-73 (only for Julia).

Does it possible that Git is trying to normalize newlines of those lines to make them consistent with the rest of the same files?

All other files look normal.

@bact bact mentioned this pull request Jan 9, 2024
@progval
Copy link
Member

progval commented Jan 9, 2024

Btw, I have made no changes to newline characters (\r\n \n) but Git reports changes in Cargo.csv, Citation File Format 1.2.0.csv, and Julia Project.csv at Line 4 and 58-62 (same line numbers for all 3 files) and Line 72-73 (only for Julia).

Does it possible that Git is trying to normalize newlines of those lines to make them consistent with the rest of the same files?

It's because these particular lines had \r\n ends while other lines in the files have \n ends and your editor fixed them to all be \n (as they should).

@bact
Copy link
Contributor Author

bact commented Jan 20, 2024

@progval So there anything I should amend further for this PR?
Thank you.

@progval progval merged commit 56de220 into codemeta:master Jan 20, 2024
@progval
Copy link
Member

progval commented Jan 20, 2024

Sorry, I forgot about it. Merged, thanks!

@bact bact deleted the fix-crosswalks-for-aggregate branch January 20, 2024 23:36
@bact
Copy link
Contributor Author

bact commented Jan 20, 2024

No worries. Thank you as well.

bact added a commit to bact/codemeta that referenced this pull request Feb 12, 2024
- Bring in `readme`, `hasSourceCode`, `isSourceCodeOf` properties (fixed by codemeta#345)
- Bring in SPDX (added by codemeta#344)
@bact bact mentioned this pull request Feb 12, 2024
tmorrell pushed a commit to caltechlibrary/codemeta that referenced this pull request Apr 11, 2025
…eta#345)

- Update crosswalk CSV files to have equal number of rows, so the `scripts/aggregate.py` can properly generate every rows (73 rows) (currently it will produce only 70, omitting the last three properties)
  - Add [ readme, hasSourceCode, isSourceCodeOf ] properties to `Citation File Format 1.2.0.csv`
  - Remove all lines with only one comma at the end of CSVs

`SciCrunchRegistry.csv`
- Line 21-74: Remove Unicode Character 'NO-BREAK SPACE' (U+00A0)

`ISO_19115-1.csv`
- Line 1: Add missing 2nd column header name
- Line 23-24: Remove a leading space from the 2nd field
- Line 37: Change `role=`pointOfContact`` to `role='pointOfContact'` (use `'` instead of ```, to be consistent with other rows)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants