-
Notifications
You must be signed in to change notification settings - Fork 93
Update crosswalks to allow the aggregation of every properties #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update crosswalk CSV files to have equal number of rows, so the `scripts/aggregate.py` can properly generate every rows (73 rows) (currently it will produce only 70, omitting the last three properties) - Add [ readme, hasSourceCode, isSourceCodeOf ] properties to `Citation File Format 1.2.0.csv` - Remove all lines with only one comma at the end of CSVs `SciCrunchRegistry.csv` - Line 21-74: Remove Unicode Character 'NO-BREAK SPACE' (U+00A0) `ISO_19115-1.csv` - Line 1: Add missing 2nd column header name - Line 23-24: Remove a leading space from the 2nd field - Line 37: Change `role=`pointOfContact`` to `role='pointOfContact'` (use `'` instead of ```, to be consistent with other rows)
|
Btw, I have made no changes to newline characters (\r\n \n) but Git reports changes in Does it possible that Git is trying to normalize newlines of those lines to make them consistent with the rest of the same files? All other files look normal. |
It's because these particular lines had |
|
@progval So there anything I should amend further for this PR? |
|
Sorry, I forgot about it. Merged, thanks! |
|
No worries. Thank you as well. |
- Bring in `readme`, `hasSourceCode`, `isSourceCodeOf` properties (fixed by codemeta#345) - Bring in SPDX (added by codemeta#344)
…eta#345) - Update crosswalk CSV files to have equal number of rows, so the `scripts/aggregate.py` can properly generate every rows (73 rows) (currently it will produce only 70, omitting the last three properties) - Add [ readme, hasSourceCode, isSourceCodeOf ] properties to `Citation File Format 1.2.0.csv` - Remove all lines with only one comma at the end of CSVs `SciCrunchRegistry.csv` - Line 21-74: Remove Unicode Character 'NO-BREAK SPACE' (U+00A0) `ISO_19115-1.csv` - Line 1: Add missing 2nd column header name - Line 23-24: Remove a leading space from the 2nd field - Line 37: Change `role=`pointOfContact`` to `role='pointOfContact'` (use `'` instead of ```, to be consistent with other rows)
Update crosswalk CSV files to have equal number of properties, so the
scripts/aggregate.pycan properly generate every properties (73 properties) (currently it will produce only 70, omitting the last three properties)Citation File Format 1.2.0.csvUpdate
SciCrunchRegistry.csvUpdate
ISO_19115-1.csv