Skip to content

Conversation

@bact
Copy link
Contributor

@bact bact commented Jan 9, 2024

bact added 2 commits January 9, 2024 08:28
- Add SPDX 2.3 crosswalk ref: https://spdx.github.io/spdx-spec/v2.3/package-information/
- Update other crosswalks to have equal number of rows, so the scripts/aggregate.py can properly generate every rows
  - Add [ readme, hasSourceCode, isSourceCodeOf ] rows to `Citation File Format 1.2.0.csv`
- Add missing column header name to ISO 19115-1
- Remove excessed white spaces from start and end of fields
@progval
Copy link
Member

progval commented Jan 9, 2024

Could you submit changes unrelated to SPDX as separate pull-requests, and remove them for this one?

Remove excessed white spaces from start and end of fields

Specifically, they are carriage-returns, we keep mixing Windows-style (\r\n) and Unix-style (\n line ends) in these files :/

@bact
Copy link
Contributor Author

bact commented Jan 9, 2024

Could you submit changes unrelated to SPDX as separate pull-requests, and remove them for this one?

Will do that. I did that in the first place because the aggregate script doesn't generate last three rows for SPDX (and others).

I will make a separated PR.

Update: For changes related to aggregation, see: #345

bact and others added 2 commits January 9, 2024 11:18
review , Annotator -> Annotation

Co-authored-by: Val Lorentz <[email protected]>
reviewBody , Annoator -> AnnotationComment

funding , PackageAttributionText -> []
Copy link
Member

@progval progval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I'll merge this next week if no one else wants to comment.

@bact
Copy link
Contributor Author

bact commented Jan 9, 2024

Thank you.
I will share this PR with SPDX community, in case they have more comments.

We can wait until the end of next week.

@progval progval merged commit 64f3bc6 into codemeta:master Jan 15, 2024
@bact bact deleted the add-crosswalks-spdx-2-3 branch January 16, 2024 17:34
bact added a commit to bact/codemeta that referenced this pull request Feb 12, 2024
- Bring in `readme`, `hasSourceCode`, `isSourceCodeOf` properties (fixed by codemeta#345)
- Bring in SPDX (added by codemeta#344)
@bact bact mentioned this pull request Feb 12, 2024
tmorrell pushed a commit to caltechlibrary/codemeta that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants