Fix CSV column inconsistency and roleName type #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`roleName` type is `Text` Line 60 of `roleName` has type `Text` followed by `URL`, which looks like a mistake. Per #240 it looks like `roleName` should be `Text` only.
Add quotes around last field of Line 62
progval
requested changes
Jan 6, 2024
Member
progval
left a comment
progval
left a comment
There was a problem hiding this comment.
Much needed fixes, thank you. Two suggestions below
Co-authored-by: Val Lorentz <[email protected]>
Co-authored-by: Val Lorentz <[email protected]>
Contributor
Author
|
Thank you for suggestions. I have made commits for all suggestions. |
progval
approved these changes
Jan 6, 2024
Contributor
Author
|
btw, roleName in https://github.com/codemeta/codemeta/blob/master/crosswalk.csv is So we now have an inconsistency between two files: |
Member
|
We periodically regenerate |
Contributor
Author
|
Got it. So it will be eventually consistent, thank you. |
tmorrell
pushed a commit
to caltechlibrary/codemeta
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CSV column inconsistency and roleName type
,that can confused CSV parser and thought that the rows have 5 columns instead of 4)roleNameshould beText or URL(currently it has Text followed by URL -Text,URL, which also make it 5 columns)By fixing these column number inconsistencies, GitHub will able to display the file as a table.
Format/description consistency