-
Notifications
You must be signed in to change notification settings - Fork 93
DOAP revision #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOAP revision #327
Conversation
|
@progval I am getting an error stating |
|
@moranegg adding a third column in the csv breaks the validator. So I added the rationale in a README file, following the example of CFF. I know you don't like this, but I don't have an alternative for now :( |
|
Thanks for trying but... Let's try and find a more sustainable solutions even if we don't have the "good" info now. please delete the README, and add this information not as a table but as remarks in an issue. thanks again for your effort :-) |
|
Then, shall we also delete the CFF readme? |
It's not; code repositories contain source code, but source code can live outside repositories. According to https://schema.org/codeRepository, this is a property of SoftwareSourceCode and links to a VCS; while hasSourceCode is a property of SoftwareApplication which links to a SoftwareSourceCode |
The CFF readme only gives rationale behind choices, not a copy of the table. You can do the same here |
|
doap:repository is property linking doap:Projects with doap:Repositories. Both are object, not URLs. doap:repository does not link to the URL, if we consider a doap:Project a SoftwareApplication, my proposal stands. |
|
The comment about the extra readme is avoiding having one extra file fer crosswalk. Per @moranegg's comment I understand we want to avoid that |
|
Oh wait, I get it. |
|
@progval I have checked more of their examples, and here is evidence of my point (from https://github.com/ewilderj/doap/blob/master/examples/doap-doap.turtle): The range of |
|
@progval ok, then pls let me know if you want me to revert the original order or not. I would keep it ordered like this, it's easier to browse. Thanks! |
|
Yes please revert to the original order, this PR won’t match the script aggregating the mappings into the crosswalk table. |
|
Ok, I will revert to the original unordered file when I get the chance |
|
Hi @dgarijo we are moving forward with v4.0 . |
|
I will amend the order this week. |
|
I have reverted and removed the "comments" section. Since there is no other place where to put the rationale, I will do so here. The rationale has source property, target property and comments explaining the rationale:
|
|
yay! checks passed this time. I hope this can be merged. |
|
I'm not sure it is correct to map Also, given that |
|
I will add the repo/location.
El mar., 2 ene. 2024 1:36 p. m., Daniel Garijo ***@***.***>
escribió:
… It's a mapping, so none of the objects will be exactly equivalent. But the
object itself (source code) has some sort of equivalence, in this case
pointing to the object denoting the code itself. I think it is ok, since
it's explained in the rationale. If you find a counter example where the
relationship would be different we can always go back.
El mar., 2 ene. 2024 1:30 p. m., Val Lorentz ***@***.***>
escribió:
> I'm not sure it is correct to map doap:repository to
> codemeta:hasSourceCode because the former links to a repository and the
> latter links to source code, which are not the same object (a repository
> contains source code); as you pointed out they are even formally defined as
> being different types.
>
> Also, given that doap:location is nested inside doap:repository, you
> might want to replace the first line with
> codeRepository,repository/location
>
> —
> Reply to this email directly, view it on GitHub
> <#327 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AALTIGWAQ6SZQCWILNKL3Y3YMP4W3AVCNFSM6AAAAAA6HQIBKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTHE3DQOJYGQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
It's a mapping, so none of the objects will be exactly equivalent. But the
object itself (source code) has some sort of equivalence, in this case
pointing to the object denoting the code itself. I think it is ok, since
it's explained in the rationale. If you find a counter example where the
relationship would be different we can always go back.
El mar., 2 ene. 2024 1:30 p. m., Val Lorentz ***@***.***>
escribió:
… I'm not sure it is correct to map doap:repository to
codemeta:hasSourceCode because the former links to a repository and the
latter links to source code, which are not the same object (a repository
contains source code); as you pointed out they are even formally defined as
being different types.
Also, given that doap:location is nested inside doap:repository, you
might want to replace the first line with
codeRepository,repository/location
—
Reply to this email directly, view it on GitHub
<#327 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTIGWAQ6SZQCWILNKL3Y3YMP4W3AVCNFSM6AAAAAA6HQIBKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTHE3DQOJYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@progval I added your suggestions. |
|
@progval thanks! |
This push has a revision of the DOAP crosswalk:
doap:shortDescanddoap:descriptionmap toschema:description, several contributor roles in DOAP map to schema:contributor