Skip to content

Conversation

@avandenbosch
Copy link
Contributor

PR for a first attempt at a MODS-codemeta crosswalk.

@moranegg
Copy link
Member

@progval can you take a look at this, please

Thanks!

@progval
Copy link
Member

progval commented Feb 16, 2023

Hmm, this syntax is very different from the rest of the crosswalks; but it's also the only one that needs to filter on XML attributes.
How about using XPath instead of the ad-hoc syntax? eg. location/url[@displayName='Download URL'] instead of <location><url displayName=""Download URL"">? This way it uses a more standard syntax and looks as much as possibly like the other crosswalks (which do use / to represent subelements).

Could you link to a reference for the terms you use? In particular, I cannot find anything about the three-letter codes at the end of roleTerm terms.

updated to XPath
@avandenbosch
Copy link
Contributor Author

The codes come from the Library of Congress MARC Relators List, terms/definitions and codes can be found at https://www.loc.gov/marc/relators/

Copy link
Member

@progval progval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, found the reference for the elements at https://www.loc.gov/standards/mods/userguide/generalapp.html

That's much clearer now.

I have a bunch of comments/questions below.

@avandenbosch avandenbosch requested a review from progval November 27, 2023 16:19
@progval progval merged commit b23e276 into codemeta:develop Nov 27, 2023
@progval progval mentioned this pull request Nov 27, 2023
progval added a commit that referenced this pull request Dec 12, 2023
progval added a commit that referenced this pull request Dec 12, 2023
Co-authored-by: Valentin Lorentz <[email protected]>
tmorrell pushed a commit to caltechlibrary/codemeta that referenced this pull request Dec 15, 2023
Co-authored-by: Valentin Lorentz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants