-
Notifications
You must be signed in to change notification settings - Fork 93
change contIntegration to continuousIntegration #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In order to minimize disruption of v3, would it make sense to keep This would still break parsers, but existing documents would remain valid when they update their context. |
|
This PR is candidate for a discussion, it changes the spec, we should label it #discussion. |
|
@progval you bring up an interesting point.
But then we have to define somewhere what this |
|
I'm not sure that's allowed in JSON-LD anyway. And sadly, no comments in JSON :(
Yeah, that's less confusing |
|
Though I agree with the namechange, I'm also a bit conflicted on breaking backward compatibility. Maybe we could publish an additional JSON-LD file that people can include in their context and that covers 2-to-3 migration, such as mapping |
|
Since we are striving with the v3.0 to keep it compatible with the v2.0, we will deprecate the term |
|
The whole reason we were thinking of naming this new version 3.0 is there were proposals for incompatible changes. In general we have been following semantic versioning, so if the decision is made to stay compatible, then I think we shou;d keep the version number in the 2.x series. |
|
Oh, and if we do, then we need to inspect other PRs to be sure there are no breaking changes. |
|
The plan with v3.0 is to add additional properties while keeping the old properties
with a "deprecated" comment in the properties description.
Which means that v3.0 while stay backward compatible but still changes the
vocabulary with new properties.
This is why I believe we can move to a v3.0 naming scheme.
In the v4.0 we will delete deprecated terms.
|
|
Again, deprecation alone does not warrant a major version bump under semantic versioning. New feature additions alone are indicated by a minor version change. Details follow from https://semver.org/ Given a version number MAJOR.MINOR.PATCH, increment the:
So, I still think this should be version 2.2.0 if we have backwards compatibility. And I find semantic versioning helpful when understanding upgrade paths. Deviating from it causes unnecessary confusion, as many people will think a major version bump is incompatible and won't upgrade as soon. |
|
Hi Matt, I do agree that this should be clear when we release the next version. From my point of view there are two options with this upcoming release:
I would like to start a vote on that and give until Monday June 19th. Thanks for the valuable feedback. |
|
Replaced by #302 (which fixes merge conflicts) |
per discussion in #243