Repository navigation
fix(audience): apply excludeFilter to broadcasts and sequences - #83
Merged
Merged
Conversation
The sequence's excludeFilter was stored but never read, and the update endpoints didn't accept it. Contacts matching it are now left out of broadcast audiences and triggered sequence enrollment (which now also honours the sequence filter). REST, MCP, the contacts list (for the recipient count) and the broadcast editor accept an exclusion. Refs #41, #79
clbotdev
force-pushed
the
issue-41-exclude-filter
branch
from
October 19, 2026 15:22
97e0af1 to
28146b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41. Part of #79.
sequences.excludeFilterwas stored but never read, and the update endpoints didn't even accept it, so "everyone except customers" still emailed customers.excludeFilter(AND NOT coalesce(...)), and triggered enrollment also honours the sequencefilter.PATCH /sequences/:idand MCPupdate_sequenceacceptexcludeFilter(nullclears it);GET /contactsand MCPlist_contactsacceptexcludeFilterso the editor's recipient count is right.Testing