Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Upper Limits to Search Log and Click Log Queue Sizes #2863

Closed
marevol opened this issue Dec 28, 2024 · 0 comments
Closed

Add Upper Limits to Search Log and Click Log Queue Sizes #2863

marevol opened this issue Dec 28, 2024 · 0 comments
Assignees
Milestone

Comments

@marevol
Copy link
Contributor

marevol commented Dec 28, 2024

We have implemented a mechanism to limit the maximum size of the search log and click log queues to prevent excessive memory usage. When the respective queue size exceeds the configured limit, a warning is logged, and the log entry is skipped.

Details:

  1. Search Log Queue
  • Added a size check to addSearchLog in SearchLogHelper.java.
  • If the size exceeds the configured limit (logging.search.max.queue.size), the log entry is skipped.
  1. Click Log Queue
  • Added a size check to addClickLog in SearchLogHelper.java.
  • If the size exceeds the configured limit (logging.click.max.queue.size), the log entry is skipped.
  1. Configuration Updates
  • Introduced two new configuration properties in fess_config.properties:
  • logging.search.max.queue.size: Sets the maximum size of the search log queue.
  • logging.click.max.queue.size: Sets the maximum size of the click log queue.
  • Default values for both have been set to 10000.

This change ensures more stable memory usage by avoiding unbounded growth of log queues.

@marevol marevol added this to the 15.0.0 milestone Dec 28, 2024
@marevol marevol self-assigned this Dec 28, 2024
@marevol marevol modified the milestones: 15.0.0, 14.19.0 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant