Skip to content

fix: Add an IDs for toolbar form fields#9823

Merged
michalsn merged 1 commit intocodeigniter4:developfrom
neznaika0:fix/toolbar-template
Dec 5, 2025
Merged

fix: Add an IDs for toolbar form fields#9823
michalsn merged 1 commit intocodeigniter4:developfrom
neznaika0:fix/toolbar-template

Conversation

@neznaika0
Copy link
Copy Markdown
Contributor

Description
Fix browser notification:

A form field element has neither an id nor a name attribute. This might prevent the browser from correctly autofilling the form.
To fix this issue, add a unique id or name attribute to a form field. This is not strictly needed, but still recommended even if you have an autocomplete attribute on the same element.

A little annoying.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn merged commit e90690b into codeigniter4:develop Dec 5, 2025
3 checks passed
@neznaika0 neznaika0 deleted the fix/toolbar-template branch December 5, 2025 19:14
@paulbalandan paulbalandan added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants