Skip to content

refactor: rename controller to Controller#9314

Merged
samsonasik merged 1 commit intocodeigniter4:developfrom
paulbalandan:rename-controller-to-Controller
Dec 11, 2024
Merged

refactor: rename controller to Controller#9314
samsonasik merged 1 commit intocodeigniter4:developfrom
paulbalandan:rename-controller-to-Controller

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

@paulbalandan paulbalandan commented Dec 11, 2024

Description
Last errors for class.nameCase

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Dec 11, 2024
@samsonasik
Copy link
Copy Markdown
Member

samsonasik commented Dec 11, 2024

it seems cause test error:

1) CodeIgniter\Router\RouteCollectionTest::testAddRecognizesCustomNamespaces
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 [
-    'home' => '\CodeIgniter\Controller',
+    'home' => '\CodeIgniter\controller',
 ]

@michalsn
Copy link
Copy Markdown
Member

michalsn commented Dec 11, 2024

Always sand in the eyes 😢

@paulbalandan paulbalandan force-pushed the rename-controller-to-Controller branch from 609379e to 562ddf2 Compare December 11, 2024 16:21
@samsonasik samsonasik merged commit 0b0126c into codeigniter4:develop Dec 11, 2024
@samsonasik
Copy link
Copy Markdown
Member

samsonasik commented Dec 11, 2024

Thank you @paulbalandan

@paulbalandan paulbalandan deleted the rename-controller-to-Controller branch December 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @samsonasik @michalsn