Skip to content

fix: auto_link() converts invalid strings like ://codeigniter.com#9180

Merged
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:fix-auto_link-bug
Sep 13, 2024
Merged

fix: auto_link() converts invalid strings like ://codeigniter.com#9180
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:fix-auto_link-bug

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Sep 8, 2024

Description
See #9165 (comment)

  • fix a bug that auto_link() converts invalid strings without a scheme like ://codeigniter.com

scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )
https://datatracker.ietf.org/doc/html/rfc3986#section-3.1

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 8, 2024
@kenjis kenjis merged commit d49d700 into codeigniter4:develop Sep 13, 2024
@kenjis kenjis deleted the fix-auto_link-bug branch September 13, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants