refactor: improve error message for missing PHP DB extensions#9160
Merged
kenjis merged 2 commits intocodeigniter4:developfrom Sep 5, 2024
Merged
refactor: improve error message for missing PHP DB extensions#9160kenjis merged 2 commits intocodeigniter4:developfrom
kenjis merged 2 commits intocodeigniter4:developfrom
Conversation
To improve the error message.
5 tasks
| throw new InvalidArgumentException('You have not selected a database type to connect to.'); | ||
| } | ||
|
|
||
| assert($this->checkDbExtension($params['DBDriver'])); |
Member
There was a problem hiding this comment.
Do we need the assert here if the method throws by itself?
Member
Author
There was a problem hiding this comment.
My intention is not to slow down CI4 at all by executing the check every time in production environment.
When zend.assertions is -1, PHP does not generate code for assert().
First, this check (error message) is only for PHP beginners. Once the extension is enabled, the check will be not needed.
And this error often happens on development environments.
On shared hosting servers, they probably know what DBMS is supported, and PHP extensions for supported DBs are installed.
Because we can name any classname.
paulbalandan
approved these changes
Aug 30, 2024
michalsn
approved these changes
Aug 31, 2024
ddevsr
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #9051
See #9158
Checklist: