Skip to content

docs: fix doc comments for Router#9151

Merged
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:fix-comment-Router.php
Aug 30, 2024
Merged

docs: fix doc comments for Router#9151
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:fix-comment-Router.php

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Aug 27, 2024

Description

  • small fix

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

Copy link
Copy Markdown
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the controller class.

@kenjis kenjis force-pushed the fix-comment-Router.php branch from 61cba69 to e3324e7 Compare August 27, 2024 00:59
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Aug 27, 2024

It returns "Controller classname or Closure", but I don't know why this method needs to return.
Because we have controllerName() for that purpose.

@kenjis kenjis changed the title docs: fix doc comment for Router::handle() docs: fix doc comments for Router::handle() Aug 27, 2024
@kenjis kenjis changed the title docs: fix doc comments for Router::handle() docs: fix doc comments for Router Aug 27, 2024
@kenjis kenjis merged commit 77f5e47 into codeigniter4:develop Aug 30, 2024
@kenjis kenjis deleted the fix-comment-Router.php branch August 30, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants