docs: [File Instance] RunTimeException if file does not exist#9037
Merged
kenjis merged 4 commits intocodeigniter4:developfrom Jul 25, 2024
christianberkman:docs-file-getsize
Merged
docs: [File Instance] RunTimeException if file does not exist#9037kenjis merged 4 commits intocodeigniter4:developfrom christianberkman:docs-file-getsize
kenjis merged 4 commits intocodeigniter4:developfrom
christianberkman:docs-file-getsize
Conversation
paulbalandan
approved these changes
Jul 23, 2024
kenjis
reviewed
Jul 24, 2024
kenjis
reviewed
Jul 24, 2024
Co-authored-by: kenjis <[email protected]>
kenjis
approved these changes
Jul 25, 2024
Member
|
@christianberkman Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
File::getSizeandFile::getSizeByUnit()may cause aRunTimeExceptionif the file does not exist or an error occurs. From the original docblock my expectation was that the functions would returnfalseon an error (e.g. file does not exist), but the calledSplFileInfo::getSize()throws a runtime error if the file does not exist.From the PHP docs
From the PHP docs it is not quite clear to me when to expect an exception and when to expect
false.If return of
falseon any error is desired, I am happy to submit a PR to catch the exception.Checklist: