Skip to content

fix: return and param types of BaseConnection#8983

Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:connection-types
Jun 22, 2024
Merged

fix: return and param types of BaseConnection#8983
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:connection-types

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

@paulbalandan paulbalandan commented Jun 21, 2024

Description

  • Make return types a little precise.
  • Fixed a param type of MockConnection

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 21, 2024
@paulbalandan paulbalandan merged commit 4e68814 into codeigniter4:develop Jun 22, 2024
@paulbalandan paulbalandan deleted the connection-types branch June 22, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @kenjis @michalsn