Skip to content

refactor: BaseBuilder::orderBy()#8970

Merged
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:refactor-orderBy
Jun 19, 2024
Merged

refactor: BaseBuilder::orderBy()#8970
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:refactor-orderBy

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Jun 18, 2024

Description

  • refactor

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code database Issues or pull requests that affect the database layer labels Jun 18, 2024
@kenjis kenjis changed the title refactor: BaseBuilder::orderBy() refactor: BaseBuilder::orderBy() Jun 18, 2024
@kenjis kenjis merged commit d6d1434 into codeigniter4:develop Jun 19, 2024
@kenjis kenjis deleted the refactor-orderBy branch June 19, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+1 more reviewer

@ddevsr ddevsr ddevsr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

database Issues or pull requests that affect the database layer refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @michalsn @ddevsr