fix: precedence of command classes with the same $name#8898
Merged
kenjis merged 2 commits intocodeigniter4:developfrom Jun 24, 2024
Merged
fix: precedence of command classes with the same $name#8898kenjis merged 2 commits intocodeigniter4:developfrom
$name#8898kenjis merged 2 commits intocodeigniter4:developfrom
Conversation
kenjis
added
the
bug
Now you can replace CI4's commands with your commands in app/Commands/.
kenjis
force-pushed
the
fix-command-discovery
branch
4 times, most recently
from
8ce24a7 to
831ffcb
Compare
kenjis
force-pushed
the
fix-command-discovery
branch
from
831ffcb to
e6b5931
Compare
michalsn
approved these changes
Jun 21, 2024
datamweb
suggested changes
Jun 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows users to override commands in the framework with commands in
App\Commands,and prevents other packages from overriding commands in the framework.
This PR changes to use the first command class discovered.
In the current implementation, the last class discovered is executed.
However, for CI4's behavior, if there is a command class in
App\Commands, it should take precedence.See also https://forum.codeigniter.com/showthread.php?tid=90877&pid=418854#pid418854
Checklist: