Skip to content

fix: Redis cache handler deleteMatching() not working when a prefix is being used#8878

Closed
TeamTizo wants to merge 1 commit intocodeigniter4:developfrom
TeamTizo:patch-1
Closed

fix: Redis cache handler deleteMatching() not working when a prefix is being used#8878
TeamTizo wants to merge 1 commit intocodeigniter4:developfrom
TeamTizo:patch-1

Conversation

@TeamTizo
Copy link
Copy Markdown

@TeamTizo TeamTizo commented May 9, 2024 •
edited by kenjis
Loading

deleteMatching wasn't working for Redis cache when a prefix was being used. adding prefix here fixed the issue.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@TeamTizo
Update RedisHandler.php
62f6efe 
deleteMatching wasn't working for Redis cache when a prefix was being used.  adding prefix here fixed the issue.
@TeamTizo TeamTizo changed the title fix Redis cache handler deleteMatching() not working when a prefix is being used fix: Redis cache handler deleteMatching() not working when a prefix is being used May 9, 2024
@kenjis
Copy link
Copy Markdown
Member

kenjis commented May 9, 2024 •
edited
Loading

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

@kenjis kenjis added tests needed Pull requests that need tests bug Verified issues on the current code behavior or pull requests that will fix them labels May 9, 2024
@ddevsr ddevsr mentioned this pull request May 11, 2024
Closed
5 tasks
@paulbalandan paulbalandan mentioned this pull request Jun 10, 2024
Merged
5 tasks
@kenjis
Copy link
Copy Markdown
Member

kenjis commented Jun 12, 2024

If you send a PR, you must add test code for it.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

This PR will not be merged because there is no test code.
Next time you submit a PR, be sure to include the test code.
Thank you.

@kenjis
Copy link
Copy Markdown
Member

kenjis commented Jun 12, 2024

Closed by #8952

@kenjis kenjis closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them tests needed Pull requests that need tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TeamTizo @kenjis