docs: Some typos in database/configuration.rst#8825
docs: Some typos in database/configuration.rst#8825kenjis merged 13 commits intocodeigniter4:developfrom
Conversation
Some typos in database/configuration.rst
Change path for SQLite3 sample in configuration.rst
Some typo in database/query_builder.rst
| .. literalinclude:: query_builder/004.php | ||
|
|
||
| Please visit the :doc:`getResult*() method <results>` page for a full | ||
| Please visit the :doc:`getResult() method <results>` page for a full |
There was a problem hiding this comment.
I agree to remove *. The * implies getResultArray() and getCustomResultObject(), but they are referred in the getResult() section.
But it is better that the destination is getResult(), not the page.
Can you change the destination?
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/documentation.rst#to-a-section
| .. literalinclude:: query_builder/005.php | ||
|
|
||
| The first parameter enables you to set whether or not the query builder query | ||
| The parameter in the first query (false) enables you to set whether or not the query builder |
There was a problem hiding this comment.
I don't get what "the first query" is.
It means "the first parameter of the getCompiledSelect() method".
So "The first parameter" is correct and no problem.
There was a problem hiding this comment.
How about adding description that the default value for the parameter is true?
…ry_builder.rst Added getCompiledSelect method parameter's default value explanation in query_builder.rst
Added link to getResult() method in results.rst
Update link to getResult() method in query_builder.rst
Correct getresult link in query_builder.rst
Change Query Helper Functions to Methods in database/index.rst
…s.rst Change backwards to backward for consistency in database/results.rst
Delete unnecessary "Example:" in database/helpers.rst
Fix getresult link in database/query_builder.rst
4 participants
Description
Some typos in database/configuration.rst
Checklist: