docs: small fixes in upgrade responses.rst#8815
Merged
kenjis merged 3 commits intocodeigniter4:developfrom Apr 30, 2024
Merged
Conversation
This page is for CI3 users. In CI3 there is no HTTP Response. So it is better to be "Upgrade Output Class".
datamweb
approved these changes
Apr 21, 2024
Comment on lines
-257
to
+258
| upgrade_pagination | ||
| upgrade_responses | ||
| upgrade_pagination |
Member
There was a problem hiding this comment.
Why this change? I assume this was alphabetical.
Member
Author
There was a problem hiding this comment.
Because I changed the page title.
Member
There was a problem hiding this comment.
The output class makes more sense from the perspective of a CI3 user.
michalsn
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist: