Skip to content

refactor: remove unnecessary BaseService::$services assignment#8609

Merged
kenjis merged 2 commits intocodeigniter4:4.5from
kenjis:deprecate-BaseConfig-services
Mar 5, 2024
Merged

refactor: remove unnecessary BaseService::$services assignment#8609
kenjis merged 2 commits intocodeigniter4:4.5from
kenjis:deprecate-BaseConfig-services

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Mar 5, 2024

Description

  • deprecate BaseService::$services. It is not used elsewhere.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.5 labels Mar 5, 2024
@kenjis kenjis merged commit 87db593 into codeigniter4:4.5 Mar 5, 2024
@kenjis kenjis deleted the deprecate-BaseConfig-services branch March 5, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants